Skip to content

Turbopack: snapshot the ModuleGraph to avoid (eventual) inconsistent graphs #88340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sokra wants to merge 7 commits into
base: sokra/eventual-consistency-no-remove-cells
Choose a base branch
from
Open

Turbopack: snapshot the ModuleGraph to avoid (eventual) inconsistent graphs #88340

sokra wants to merge 7 commits into from

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 9, 2026 •
edited
Loading

What?

Refactor ModuleGraph to be a strongly consistent snapshot of the module graph. This should avoid eventually consistency problems where different versions of single module graphs do not fit together.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 9, 2026
This was referenced Jan 9, 2026
Merged
Merged
Open
Open
Merged
Merged
Merged
Merged
Merged
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 9, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra mentioned this pull request Jan 9, 2026
Draft
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 9, 2026

Allow CI Workflow Run

  • approve CI run for commit: 52d9dd0

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@sokra sokra changed the title Turbopack: pass binding info as operation to module graph Turbopack: snapshot the ModuleGraph to avoid (eventual) inconsistent graphs Jan 9, 2026
@sokra sokra marked this pull request as ready for review January 9, 2026 17:57
@sokra sokra requested a review from mischnic January 9, 2026 17:57
@sokra sokra force-pushed the sokra/parallel-backend branch from 9b8b94f to e70e940 Compare January 12, 2026 09:23
@sokra sokra force-pushed the sokra/module-graph-consistency branch from 52d9dd0 to 965d41d Compare January 12, 2026 09:23
This was referenced Jan 12, 2026
Open
Open
Open
vercel[bot]
vercel bot reviewed Jan 12, 2026
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing sokra/module-graph-consistency (a70d6f0) with sokra/eventual-consistency-no-remove-cells (140543b)

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026 •
edited
Loading

Failing test suites

Commit: f872016 | About building and testing Next.js

pnpm test-dev test/e2e/app-dir/next-config-ts-native-ts/export-default/next-config-ts-export-default-esm.test.ts (job)

  • next-config-ts-type-error-esm > should throw with type error on build (ESM) (DD)
Expand output

● next-config-ts-type-error-esm › should throw with type error on build (ESM)

FetchError: request to http://localhost:38195/ failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/[email protected][email protected]/node_modules/node-fetch/lib/index.js:1491:11)

pnpm test-dev test/e2e/app-dir/next-config-ts-native-ts/export-default/next-config-ts-export-default-cjs.test.ts (job)

  • next-config-ts-type-error-esm > should throw with type error on build (ESM) (DD)
Expand output

● next-config-ts-type-error-esm › should throw with type error on build (ESM)

FetchError: request to http://localhost:46613/ failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/[email protected][email protected]/node_modules/node-fetch/lib/index.js:1491:11)

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 440ms 440ms ✓ ▁▂▂▂▂
Cold (First Request) 1.128s 1.127s ✓ ▁▄▄▄▄
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Warm (Ready in log) 442ms 443ms ✓ ▁▁▁▁▁
Warm (First Request) 350ms 340ms ✓ ▁▁▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▁▁▁█
Cold (Ready in log) 438ms 438ms ✓ ▃▄▁▄█
Cold (First Request) 1.841s 1.831s ✓ ▂▂▁▂█
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁█
Warm (Ready in log) 437ms 438ms ✓ ▃▃▁▄█
Warm (First Request) 1.844s 1.851s ✓ ▂▂▁▂█

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.056s 4.120s ✓ ▁▁▁▁▁
Cached Build 4.079s 4.133s ✓ ▂▁▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.014s 14.057s ✓ ▁▁▁▁█
Cached Build 14.086s 14.142s ✓ ▁▁▁▁█
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **431 kB** → **431 kB** ✅ -7 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 789 B 792 B ✓
Total 789 B 792 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 450 B ✓
Total 450 B 450 B ✓

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.8 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 250 B 253 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.7 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 226 kB ⚠️ +245 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 242 kB ✓
Total 366 kB 367 kB ⚠️ +470 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 652 B 653 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.1 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.7 kB 34.9 kB ⚠️ +191 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.66 MB 3.67 MB 🔴 +8.49 kB (+0%)
index.pack gzip 102 kB 99.5 kB 🟢 2.36 kB (-2%)
index.pack.old gzip 100 kB 100 kB ✓
Total 3.86 MB 3.87 MB ⚠️ +6.38 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 304 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 301 kB 301 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ⚠️ +1 B

mischnic
mischnic reviewed Jan 12, 2026
View reviewed changes
@sokra sokra changed the base branch from sokra/parallel-backend to graphite-base/88340 January 13, 2026 14:31
@sokra sokra force-pushed the sokra/module-graph-consistency branch from 965d41d to f872016 Compare January 13, 2026 15:43
@sokra sokra force-pushed the graphite-base/88340 branch from e70e940 to afefad3 Compare January 13, 2026 15:43
@sokra sokra changed the base branch from graphite-base/88340 to sokra/eventual-consistency-no-remove-cells January 13, 2026 15:44
@sokra sokra mentioned this pull request Jan 13, 2026
Open
@sokra sokra requested a review from mischnic January 13, 2026 16:39
@sokra sokra force-pushed the sokra/eventual-consistency-no-remove-cells branch from afefad3 to 22a574e Compare January 13, 2026 16:40
@sokra sokra force-pushed the sokra/module-graph-consistency branch from f872016 to 7f4e685 Compare January 13, 2026 16:40
@sokra sokra force-pushed the sokra/eventual-consistency-no-remove-cells branch from 22a574e to 140543b Compare January 13, 2026 20:24
@sokra sokra force-pushed the sokra/module-graph-consistency branch from 7f4e685 to a70d6f0 Compare January 13, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@mischnic mischnic Awaiting requested review from mischnic

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sokra @nextjs-bot @mischnic